Type() can hamper productivity
This code insight detects each time type() is used in codeWhy you should care
The function isinstance is the best-equipped to handle type checking because it supports inheritance (e.g. an instance of a derived class is an instance of a base class, too). Therefore isinstance should be used whenever type comparison is requiredBusiness Impacts
Type() negatively affects productivity bcause it creates improper comparisons
[nz_btn text="Production Risk" target="_self" animate="false" animation_type="ghost" color="pink" size="small" shape="rounded" type="normal" hover_normal="opacity" hover_ghost="fill" link="http://casthighlight.wpengine.com/category/product/indicators-methodology/innovation/" icon="icon-office"]
CAST recommendations
References
http://docs.quantifiedcode.com/python-code-patterns/readability/do_not_compare_types_use_isinstance.htmlAbout CAST and Highlight’s Code Insights
Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.
For reference only. For the complete details please refer the original article
https://doc.casthighlight.com/alt_instanceof-avoid-type-in-conditions/
https://doc.casthighlight.com/alt_instanceof-avoid-type-in-conditions/
Comments